Skip to content

Commit

Permalink
fix(experiment banners): fix running time/sample size comparison sign (
Browse files Browse the repository at this point in the history
  • Loading branch information
jurajmajerik authored Apr 16, 2024
1 parent 3e68f1e commit 5308b79
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions frontend/src/scenes/experiments/ExperimentView/components.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export function ActionBanner(): JSX.Element {
// Win probability only slightly over 0.9 and the recommended sample/time just met -> proceed with caution
if (
experimentInsightType === InsightType.FUNNELS &&
funnelResultsPersonsTotal > recommendedSampleSize + 50 &&
funnelResultsPersonsTotal < recommendedSampleSize + 50 &&
winProbability < 0.93
) {
return (
Expand All @@ -432,7 +432,7 @@ export function ActionBanner(): JSX.Element {

if (
experimentInsightType === InsightType.TRENDS &&
actualRunningTime > recommendedRunningTime + 2 &&
actualRunningTime < recommendedRunningTime + 2 &&
winProbability < 0.93
) {
return (
Expand Down

0 comments on commit 5308b79

Please sign in to comment.