fix: assume typeless series nodes are of type events node (#19550)

PostHog · Jan 4, 2024 · 5022b14 · 5022b14
1 parent fb2f348
commit 5022b14
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.test.ts b/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.test.ts
@@ -72,6 +72,14 @@ describe('actionsAndEventsToSeries', () => {
         expect(result[1].name).toEqual('item1')
         expect(result[2].name).toEqual('item2')
     })
+
+    it('assumes typeless series is an event series', () => {
+        const events: ActionFilter[] = [{ id: '$pageview', order: 0, name: 'item1' } as any]
+
+        const result = actionsAndEventsToSeries({ events })
+
+        expect(result[0].kind === NodeKind.EventsNode)
+    })
 })
 
 describe('cleanHiddenLegendIndexes', () => {

diff --git a/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts b/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts
@@ -73,7 +73,7 @@ export const actionsAndEventsToSeries = ({
                     id: f.id,
                     ...shared,
                 }
-            } else if (f.type === 'events') {
+            } else {
                 return {
                     kind: NodeKind.EventsNode,
                     event: f.id,