Skip to content

Commit

Permalink
Added notes
Browse files Browse the repository at this point in the history
  • Loading branch information
benjackwhite committed Mar 18, 2024
1 parent 6090da2 commit 4f4c559
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion ee/api/rbac/access_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

from ee.models.rbac.access_control import AccessControl
from posthog.api.routing import TeamAndOrgViewSetMixin
from posthog.constants import AvailableFeature
from posthog.models.personal_api_key import API_SCOPE_OBJECTS
from posthog.permissions import PremiumFeaturePermission


# TODO: Validate that an access control can only have one of team, organization_member, or role
Expand Down Expand Up @@ -48,9 +50,11 @@ class AccessControlViewSet(
viewsets.GenericViewSet,
):
scope_object = "INTERNAL"
# TODO: Add permissions
serializer_class = AccessControlSerializer
queryset = AccessControl.objects.all()
permission_classes = [PremiumFeaturePermission]
# NOTE: DashboardCollaborators that should be replaced by this use ADVANCED_PERMISSIONS - what do with that?
premium_feature = AvailableFeature.PROJECT_BASED_PERMISSIONING

def filter_queryset(self, queryset):
params = self.request.GET
Expand Down

0 comments on commit 4f4c559

Please sign in to comment.