perf: Rewrite comparison operations that use property group values to…

… support skip indices (#24381) Co-authored-by: Marius Andra <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Aug 27, 2024 · 4d99a9c · 4d99a9c
1 parent 547d9f5
commit 4d99a9c
Show file tree

Hide file tree

Showing 6 changed files with 531 additions and 75 deletions.
diff --git a/frontend/src/queries/schema.json b/frontend/src/queries/schema.json
@@ -5159,7 +5159,7 @@
                     "type": "string"
                 },
                 "propertyGroupsMode": {
-                    "enum": ["enabled", "disabled"],
+                    "enum": ["enabled", "disabled", "optimized"],
                     "type": "string"
                 },
                 "s3TableUseInvalidColumns": {

diff --git a/frontend/src/queries/schema.ts b/frontend/src/queries/schema.ts
@@ -210,7 +210,7 @@ export interface HogQLQueryModifiers {
     personsJoinMode?: 'inner' | 'left'
     bounceRatePageViewMode?: 'count_pageviews' | 'uniq_urls' | 'uniq_page_screen_autocaptures'
     sessionTableVersion?: 'auto' | 'v1' | 'v2'
-    propertyGroupsMode?: 'enabled' | 'disabled'
+    propertyGroupsMode?: 'enabled' | 'disabled' | 'optimized'
 }
 
 export interface DataWarehouseEventsModifier {

diff --git a/frontend/src/scenes/debug/Modifiers.tsx b/frontend/src/scenes/debug/Modifiers.tsx
@@ -121,6 +121,7 @@ export function Modifiers<Q extends { response?: Record<string, any>; modifiers?
                     options={[
                         { value: 'enabled', label: 'Enabled' },
                         { value: 'disabled', label: 'Disabled' },
+                        { value: 'optimized', label: 'Enabled, with Optimizations' },
                     ]}
                     onChange={(value) =>
                         setQuery({