fix(survey): fix question type placement and add open feedback templa…

…te (#18125) * move survey question type back up * add open feedback template * fix description
PostHog · Oct 20, 2023 · 4b00140 · 4b00140
1 parent 1900db9
commit 4b00140
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 21 deletions.
diff --git a/frontend/__snapshots__/scenes-app-notebooks--bullet-list.png b/frontend/__snapshots__/scenes-app-notebooks--bullet-list.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--empty-notebook.png b/frontend/__snapshots__/scenes-app-notebooks--empty-notebook.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--headings.png b/frontend/__snapshots__/scenes-app-notebooks--headings.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--notebook-not-found.png b/frontend/__snapshots__/scenes-app-notebooks--notebook-not-found.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--notebooks-list.png b/frontend/__snapshots__/scenes-app-notebooks--notebooks-list.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--numbered-list.png b/frontend/__snapshots__/scenes-app-notebooks--numbered-list.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--recordings-playlist.png b/frontend/__snapshots__/scenes-app-notebooks--recordings-playlist.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--text-formats.png b/frontend/__snapshots__/scenes-app-notebooks--text-formats.png
diff --git a/frontend/__snapshots__/scenes-app-notebooks--text-only-notebook.png b/frontend/__snapshots__/scenes-app-notebooks--text-only-notebook.png
diff --git a/frontend/__snapshots__/scenes-app-surveys--new-survey.png b/frontend/__snapshots__/scenes-app-surveys--new-survey.png
diff --git a/frontend/__snapshots__/scenes-app-surveys--survey-templates.png b/frontend/__snapshots__/scenes-app-surveys--survey-templates.png
diff --git a/frontend/src/scenes/surveys/SurveyEdit.tsx b/frontend/src/scenes/surveys/SurveyEdit.tsx
@@ -167,27 +167,6 @@ export default function SurveyEdit(): JSX.Element {
                                                     content: (
                                                         <Group name={`questions.${index}`} key={index}>
                                                             <div className="flex flex-col gap-2">
-                                                                <Field name="question" label="Label">
-                                                                    <LemonInput value={question.question} />
-                                                                </Field>
-
-                                                                <Field
-                                                                    name="description"
-                                                                    label="Description (optional)"
-                                                                >
-                                                                    {({ value, onChange }) => (
-                                                                        <HTMLEditor
-                                                                            value={value}
-                                                                            onChange={onChange}
-                                                                            writingHTMLDescription={
-                                                                                writingHTMLDescription
-                                                                            }
-                                                                            setWritingHTMLDescription={
-                                                                                setWritingHTMLDescription
-                                                                            }
-                                                                        />
-                                                                    )}
-                                                                </Field>
                                                                 <Field
                                                                     name="type"
                                                                     label="Question type"
@@ -335,6 +314,27 @@ export default function SurveyEdit(): JSX.Element {
                                                                         ]}
                                                                     />
                                                                 </Field>
+                                                                <Field name="question" label="Label">
+                                                                    <LemonInput value={question.question} />
+                                                                </Field>
+
+                                                                <Field
+                                                                    name="description"
+                                                                    label="Description (optional)"
+                                                                >
+                                                                    {({ value, onChange }) => (
+                                                                        <HTMLEditor
+                                                                            value={value}
+                                                                            onChange={onChange}
+                                                                            writingHTMLDescription={
+                                                                                writingHTMLDescription
+                                                                            }
+                                                                            setWritingHTMLDescription={
+                                                                                setWritingHTMLDescription
+                                                                            }
+                                                                        />
+                                                                    )}
+                                                                </Field>
                                                                 {survey.questions.length > 1 && (
                                                                     <Field name="optional" className="my-2">
                                                                         <LemonCheckbox

diff --git a/frontend/src/scenes/surveys/constants.tsx b/frontend/src/scenes/surveys/constants.tsx
@@ -148,6 +148,7 @@ export const NEW_SURVEY: NewSurvey = {
 }
 
 export enum SurveyTemplateType {
+    OpenFeedback = 'Open feedback',
     Interview = 'User interview',
     NPS = 'Net promoter score (NPS)',
     CSAT = 'Customer satisfaction score (CSAT)',
@@ -244,4 +245,14 @@ export const defaultSurveyTemplates = [
         ],
         description: 'Find out if it was something you said.',
     },
+    {
+        type: SurveyTemplateType.OpenFeedback,
+        questions: [
+            {
+                type: SurveyQuestionType.Open,
+                question: 'What can we do to improve our product?',
+            },
+        ],
+        description: "Let your users share what's on their mind.",
+    },
 ]