Skip to content

Commit

Permalink
refactor: More clearly separate writer from temporary file
Browse files Browse the repository at this point in the history
We now should be more explicit about what is the context in which the
batch export temporary file is alive. The writer outlives this
context, so it can be used by callers to, for example, check how many
records were written.
  • Loading branch information
tomasfarias committed Mar 22, 2024
1 parent cf9bf65 commit 4811dd5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions posthog/temporal/batch_exports/s3_batch_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
from posthog.temporal.batch_exports.base import PostHogWorkflow
from posthog.temporal.batch_exports.batch_exports import (
CreateBatchExportRunInputs,
FlushCallable,
JSONLBatchExportWriter,
ParquetBatchExportWriter,
UnsupportedFileFormatError,
UpdateBatchExportRunStatusInputs,
create_export_run,
default_fields,
Expand Down

0 comments on commit 4811dd5

Please sign in to comment.