fix(comms): support panel value fixes (#25111)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Sep 20, 2024 · 47b7d6d · 47b7d6d
1 parent 423878c
commit 47b7d6d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/...nd/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--dark.png b/...nd/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--dark.png
diff --git a/...d/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--light.png b/...d/__snapshots__/scenes-app-sidepanels--side-panel-support-with-email--light.png
diff --git a/frontend/src/lib/components/Support/SupportForm.tsx b/frontend/src/lib/components/Support/SupportForm.tsx
@@ -15,7 +15,7 @@ import { LemonField } from 'lib/lemon-ui/LemonField'
 import { LemonFileInput } from 'lib/lemon-ui/LemonFileInput/LemonFileInput'
 import { LemonSelect } from 'lib/lemon-ui/LemonSelect/LemonSelect'
 import { LemonTextArea } from 'lib/lemon-ui/LemonTextArea/LemonTextArea'
-import { useEffect, useRef } from 'react'
+import { useRef } from 'react'
 import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic'
 import { userLogic } from 'scenes/userLogic'
 
@@ -70,13 +70,14 @@ export function SupportForm(): JSX.Element | null {
         },
     })
 
-    useEffect(() => {
-        if (sendSupportRequest.kind === 'bug') {
+    const changeKind = (kind: SupportTicketKind): void => {
+        setSendSupportRequestValue('kind', kind)
+        if (kind === 'bug') {
             setSendSupportRequestValue('severity_level', 'medium')
         } else {
             setSendSupportRequestValue('severity_level', 'low')
         }
-    }, [sendSupportRequest.kind])
+    }
 
     return (
         <Form
@@ -97,7 +98,7 @@ export function SupportForm(): JSX.Element | null {
                 </>
             )}
             <LemonField name="kind" label="Message type">
-                <LemonSegmentedButton fullWidth options={SUPPORT_TICKET_OPTIONS} />
+                <LemonSegmentedButton onChange={changeKind} fullWidth options={SUPPORT_TICKET_OPTIONS} />
             </LemonField>
             <LemonField name="target_area" label="Topic">
                 <LemonSelect

diff --git a/frontend/src/lib/components/Support/supportLogic.ts b/frontend/src/lib/components/Support/supportLogic.ts
@@ -544,7 +544,7 @@ export const supportLogic = kea<supportLogicType>([
 
                 actions.openSupportForm({
                     kind: Object.keys(SUPPORT_KIND_TO_SUBJECT).includes(kind) ? kind : null,
-                    target_area: Object.keys(TARGET_AREA_TO_NAME).includes(area) ? area : null,
+                    target_area: getLabelBasedOnTargetArea(area) ? area : null,
                     severity_level: Object.keys(SEVERITY_LEVEL_TO_NAME).includes(severity) ? severity : null,
                     isEmailFormOpen: isEmailFormOpen ?? 'false',
                 })