Skip to content

Commit

Permalink
chore: remove unused prop and CSS (#17838)
Browse files Browse the repository at this point in the history
  • Loading branch information
daibhin authored Oct 6, 2023
1 parent 1df3795 commit 430dea1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 30 deletions.
2 changes: 1 addition & 1 deletion frontend/src/queries/nodes/InsightViz/InsightContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export function InsightContainer({
) : null}
{/* These are filters that are reused between insight features. They each have generic logic that updates the url */}
<Card
title={disableHeader ? null : <InsightDisplayConfig disableTable={!!disableTable} />}
title={disableHeader ? null : <InsightDisplayConfig />}
data-attr="insights-graph"
className="insights-graph-container"
bordered={!embedded}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ import { axisLabel } from 'scenes/insights/aggregationAxisFormat'
import { ChartDisplayType } from '~/types'
import { ShowLegendFilter } from 'scenes/insights/EditorFilters/ShowLegendFilter'

interface InsightDisplayConfigProps {
disableTable: boolean
}

export function InsightDisplayConfig({ disableTable }: InsightDisplayConfigProps): JSX.Element {
export function InsightDisplayConfig(): JSX.Element {
const { insightProps } = useValues(insightLogic)
const {
showDateRange,
Expand Down Expand Up @@ -90,7 +86,7 @@ export function InsightDisplayConfig({ disableTable }: InsightDisplayConfigProps
return (
<div className="flex justify-between items-center flex-wrap" data-attr="insight-filters">
<div className="flex items-center space-x-2 flex-wrap my-2 gap-y-2">
{showDateRange && !disableTable && (
{showDateRange && (
<ConfigFilter>
<InsightDateFilter disabled={disableDateRange} />
</ConfigFilter>
Expand Down
23 changes: 0 additions & 23 deletions frontend/src/scenes/experiments/Experiment.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,6 @@
.insights-graph-container {
margin-bottom: 1rem;

.ant-card-head {
border-bottom: 1px solid var(--border);
min-height: unset;
background-color: var(--bg-light);
padding-left: 1rem;
padding-right: 1rem;

.ant-card-head-title {
padding: 0.5rem 0;

span.filter {
font-size: 14px;

&:not(:last-child) {
margin-right: 0.5rem;
}

span.head-title-item {
margin-right: 0.5rem;
}
}
}
}
.display-config-inner {
display: flex;
align-items: center;
Expand Down

0 comments on commit 430dea1

Please sign in to comment.