fix: Gravatar over-fetching

PostHog · Nov 23, 2023 · 3d51002 · 3d51002
1 parent 6e51b92
commit 3d51002
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/frontend/src/lib/lemon-ui/ProfilePicture/ProfilePicture.tsx b/frontend/src/lib/lemon-ui/ProfilePicture/ProfilePicture.tsx
@@ -48,12 +48,7 @@ export function ProfilePicture({
         if (emailOrNameWithEmail) {
             const emailHash = md5(emailOrNameWithEmail.trim().toLowerCase())
             const tentativeUrl = `https://www.gravatar.com/avatar/${emailHash}?s=96&d=404`
-            // The image will be cached, so it's best to do GET request check before trying to render it
-            void fetch(tentativeUrl).then((response) => {
-                if (response.status === 200) {
-                    setGravatarUrl(tentativeUrl)
-                }
-            })
+            setGravatarUrl(tentativeUrl)
         }
     }, [email])
 
@@ -64,6 +59,7 @@ export function ProfilePicture({
                 src={gravatarUrl}
                 title={title || `This is the Gravatar for ${combinedNameAndEmail}`}
                 alt=""
+                onError={() => setGravatarUrl(null)}
             />
         )
     } else {