Skip to content

Commit

Permalink
chore: upgrade d3 (#14442)
Browse files Browse the repository at this point in the history
* chore: upgrade d3

* Update UI snapshots for `chromium` (1)

* fix test module mapping

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
pauldambra and github-actions[bot] authored Feb 28, 2023
1 parent 1535170 commit 36f08ce
Show file tree
Hide file tree
Showing 5 changed files with 201 additions and 150 deletions.
Binary file modified frontend/__snapshots__/exporter-exporter--dashboard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions frontend/src/scenes/paths/renderPaths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const appendPathNodes = (
const startNodeColor = c && d3.color(c) ? d3.color(c) : d3.color('#5375ff')
return startNodeColor
})
.on('mouseover', (data: PathNodeData) => {
.on('mouseover', (_event: MouseEvent, data: PathNodeData) => {
if (data.y1 - data.y0 > HIDE_PATH_CARD_HEIGHT) {
return
}
Expand Down Expand Up @@ -117,7 +117,7 @@ const appendPathLinks = (
.attr('stroke-width', (d: PathNodeData) => {
return Math.max(1, d.width)
})
.on('mouseover', (data: PathNodeData) => {
.on('mouseover', (_event: MouseEvent, data: PathNodeData) => {
svg.select(`#path-${data.index}`).attr('stroke', 'blue')
if (data?.source?.targetLinks.length === 0) {
return
Expand Down
2 changes: 2 additions & 0 deletions jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ const config: Config = {
'^scenes/(.*)$': '<rootDir>/scenes/$1',
'^antd/es/(.*)$': 'antd/lib/$1',
'^react-virtualized/dist/es/(.*)$': 'react-virtualized/dist/commonjs/$1',
d3: '<rootDir>/../../node_modules/d3/dist/d3.min.js',
'^d3-(.*)$': `d3-$1/dist/d3-$1`,
},

// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
Expand Down
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"@react-hook/size": "^2.1.2",
"@sentry/react": "7.22.0",
"@testing-library/dom": ">=7.21.4",
"@types/d3-sankey": "^0.11.2",
"@types/md5": "^2.3.0",
"@types/react-input-autosize": "^2.2.1",
"@types/react-textfit": "^1.1.0",
Expand All @@ -87,7 +86,7 @@
"clsx": "^1.1.1",
"core-js": "3.15.2",
"cors": "^2.8.5",
"d3": "^5.15.0",
"d3": "^7.8.2",
"d3-sankey": "^0.12.3",
"dayjs": "^1.10.7",
"esbuild": "^0.14.54",
Expand Down Expand Up @@ -181,8 +180,8 @@
"@testing-library/user-event": "^13.5.0",
"@types/chartjs-plugin-crosshair": "^1.1.1",
"@types/clone": "^2.1.1",
"@types/d3": "^7.0.0",
"@types/d3-sankey": "^0.11.2",
"@types/d3": "^7.4.0",
"@types/d3-sankey": "^0.12.1",
"@types/jest": "^29.2.3",
"@types/jest-image-snapshot": "^6.1.0",
"@types/md5": "^2.3.0",
Expand Down
Loading

0 comments on commit 36f08ce

Please sign in to comment.