Fix error of no result at all

Fixes POSTHOG-TMM
PostHog · Apr 26, 2024 · 35b9ade · 35b9ade
1 parent f1a3920
commit 35b9ade
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/posthog/tasks/exports/test/csv_renders/hogql_no_result.json b/posthog/tasks/exports/test/csv_renders/hogql_no_result.json
@@ -0,0 +1,7 @@
+{
+    "csv_rows": ["error", "No data available or unable to format for export.", ""],
+    "response": {
+        "columns": null,
+        "hasMore": null
+    }
+}
diff --git a/posthog/tasks/exports/test/test_csv_exporter_renders.py b/posthog/tasks/exports/test/test_csv_exporter_renders.py
@@ -62,7 +62,9 @@ def test_csv_rendering(mock_settings, mock_process_query, mock_request, filename
         elif fixture["response"].get("results") is not None:
             mock_process_query.return_value = fixture["response"]
         else:
-            mock_process_query.return_value = {"results": fixture["response"].pop("result"), **fixture["response"]}
+            mock_process_query.return_value = fixture["response"]
+            if "result" in fixture["response"]:
+                mock_process_query.return_value["results"] = fixture["response"].pop("result")
         csv_exporter.export_tabular(asset)
         csv_rows = asset.content.decode("utf-8").split("\r\n")