max(max_steps)

PostHog · Nov 14, 2024 · 34370ca · 34370ca
1 parent 6dda214
commit 34370ca
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/posthog/hogql_queries/insights/funnels/base.py b/posthog/hogql_queries/insights/funnels/base.py
@@ -1167,7 +1167,7 @@ def _get_step_counts_query(self, outer_select: list[ast.Expr], inner_select: lis
                 )
             ),
             group_by=group_by_columns,
-            having=parse_expr("steps = max_steps"),
+            having=parse_expr("steps = max(max_steps)"),
         )
 
     def actor_query(

diff --git a/posthog/queries/funnels/funnel.py b/posthog/queries/funnels/funnel.py
@@ -50,7 +50,7 @@ def get_step_counts_query(self):
                         {steps_per_person_query}
                 )
             ) GROUP BY aggregation_target, steps {breakdown_clause}
-            HAVING steps = max_steps
+            HAVING steps = max(max_steps)
         """
 
     def get_step_counts_without_aggregation_query(self):

diff --git a/posthog/queries/funnels/funnel_strict.py b/posthog/queries/funnels/funnel_strict.py
@@ -26,8 +26,8 @@ def get_step_counts_query(self):
                 SELECT aggregation_target, steps, max(steps) over (PARTITION BY aggregation_target {breakdown_clause}) as max_steps {self._get_step_time_names(max_steps)} {breakdown_clause} {inner_timestamps} {self._get_matching_events(max_steps)} {self._get_person_and_group_properties()} FROM (
                         {steps_per_person_query}
                 )
-            ) WHERE steps = max_steps
-            GROUP BY aggregation_target, steps {breakdown_clause}
+            ) GROUP BY aggregation_target, steps {breakdown_clause}
+            HAVING steps = max(max_steps)
         """
 
     def get_step_counts_without_aggregation_query(self):

diff --git a/posthog/queries/funnels/funnel_unordered.py b/posthog/queries/funnels/funnel_unordered.py
@@ -81,7 +81,7 @@ def get_step_counts_query(self):
                         {union_query}
                 )
             ) GROUP BY aggregation_target, steps {breakdown_clause}
-            HAVING steps = max_steps
+            HAVING steps = max(max_steps)
         """
 
     def get_step_counts_without_aggregation_query(self):