remove hideSideBarMobile action

PostHog · Dec 28, 2023 · 31eaad0 · 31eaad0
1 parent d4d3941
commit 31eaad0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/frontend/src/layout/navigation/SideBar/PageButton.tsx b/frontend/src/layout/navigation/SideBar/PageButton.tsx
@@ -1,11 +1,10 @@
-import { useActions, useValues } from 'kea'
+import { useValues } from 'kea'
 import { LemonButton, LemonButtonProps, SideAction } from 'lib/lemon-ui/LemonButton'
 import { LemonTag } from 'lib/lemon-ui/LemonTag/LemonTag'
 import { sceneLogic } from 'scenes/sceneLogic'
 import { sceneConfigurations } from 'scenes/scenes'
 import { Scene } from 'scenes/sceneTypes'
 
-import { navigationLogic } from '~/layout/navigation/navigationLogic'
 import { SidebarChangeNoticeTooltip } from '~/layout/navigation/SideBar/SidebarChangeNotice'
 import { dashboardsModel } from '~/models/dashboardsModel'
 
@@ -22,7 +21,6 @@ export interface PageButtonProps extends Pick<LemonButtonProps, 'icon' | 'onClic
 export function PageButton({ title, sideAction, identifier, highlight, ...buttonProps }: PageButtonProps): JSX.Element {
     const { activeScene } = useValues(sceneLogic)
     const { sceneBreadcrumbKeys } = useValues(breadcrumbsLogic)
-    const { hideSideBarMobile } = useActions(navigationLogic)
     const { lastDashboardId } = useValues(dashboardsModel)
 
     const isActiveSide: boolean = !!sideAction?.identifier && activeScene === sideAction.identifier
@@ -43,7 +41,7 @@ export function PageButton({ title, sideAction, identifier, highlight, ...button
                         fullWidth
                         status={buttonStatus}
                         active={isActive}
-                        onClick={hideSideBarMobile}
+                        onClick={() => {}}
                         sideAction={{
                             ...sideAction,
                             'data-attr': sideAction.identifier
@@ -61,7 +59,7 @@ export function PageButton({ title, sideAction, identifier, highlight, ...button
                         status={buttonStatus}
                         active={isActive}
                         data-attr={`menu-item-${identifier.toString().toLowerCase()}`}
-                        onClick={hideSideBarMobile}
+                        onClick={() => {}}
                         sideIcon={null}
                         {...buttonProps}
                     >

diff --git a/frontend/src/layout/navigation/navigationLogic.ts b/frontend/src/layout/navigation/navigationLogic.ts
@@ -26,7 +26,6 @@ export const navigationLogic = kea<navigationLogicType>([
         actions: [eventUsageLogic, ['reportProjectNoticeDismissed']],
     })),
     actions({
-        hideSideBarMobile: true,
         openSitePopover: true,
         closeSitePopover: true,
         toggleSitePopover: true,