Skip to content

Commit

Permalink
Use BuildJet ARM runners for ARM builds
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes committed Oct 9, 2023
1 parent f47e72f commit 319df4d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/build-hogql-parser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,21 @@ jobs:
timeout-minutes: 120 # The Linux ARM builds are painfully slow
strategy:
matrix:
os: [ubuntu-22.04, macos-12]
# ARM emulation is reasonably fast on macOS, but insanely slow (20x longer) on Linux runners
os: [ubuntu-22.04, buildjet-2vcpu-ubuntu-2204-arm, macos-12]

steps:
- uses: actions/checkout@v4

- name: Set up QEMU for Linux ARM builds
if: runner.os == 'Linux'
uses: docker/setup-qemu-action@v3
- if: ${{ !endsWith(matrix.os, '-arm') }}
uses: actions/setup-python@v4
with:
platforms: linux/arm64
python-version: '3.10'

- uses: actions/setup-python@v3
- if: ${{ endsWith(matrix.os, '-arm') }}
uses: deadsnakes/[email protected] # Unfortunately actions/setup-python@v4 just doesn't work on ARM! This does
with:
python-version: '3.10'

- name: Build sdist
if: matrix.os == 'ubuntu-22.04' # Only build the sdist once
Expand Down
2 changes: 1 addition & 1 deletion hogql_parser/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ before-all = [
"cp out/usr/local/lib64/libantlr4-runtime.so* /usr/lib64/",
"ldconfig",
]
archs = ["x86_64", "aarch64"]
archs = ["native"] # We run x86_64 and aarch64 as separate CI jobs, and we want native in each case as emulation is slow
manylinux-x86_64-image = "manylinux_2_28"
manylinux-aarch64-image = "manylinux_2_28"
3 changes: 3 additions & 0 deletions plugin-server/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ max_line_length = 120

[*.md]
trim_trailing_whitespace = false

[*.{yml,yaml}]
indent_size = 2

0 comments on commit 319df4d

Please sign in to comment.