chore: remove onboarding reverse proxy ff (#22638)

* turn off the onboarding reverse proxy ff

* Update onboardingLogic.tsx

* Update onboardingLogic.tsx

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

frontend/src/lib/constants.tsx

@@ -192,7 +192,6 @@ export const FEATURE_FLAGS = {
     REPLAY_ERROR_CLUSTERING: 'session-replay-error-clustering', // owner: #team-replay
     AUDIT_LOGS_ACCESS: 'audit-logs-access', // owner: #team-growth
     SUBSCRIBE_FROM_PAYGATE: 'subscribe-from-paygate', // owner: #team-growth
-    REVERSE_PROXY_ONBOARDING: 'reverse-proxy-onboarding', // owner: @zlwaterfield
     SESSION_REPLAY_MOBILE_ONBOARDING: 'session-replay-mobile-onboarding', // owner: #team-replay
     HEATMAPS_UI: 'heatmaps-ui', // owner: @benjackwhite
     THEME: 'theme', // owner: @aprilfools

frontend/src/scenes/onboarding/onboardingLogic.tsx

@@ -1,7 +1,6 @@
 import { actions, connect, kea, listeners, path, props, reducers, selectors } from 'kea'
 import { actionToUrl, router, urlToAction } from 'kea-router'
-import { FEATURE_FLAGS } from 'lib/constants'
-import { featureFlagLogic, FeatureFlagsSet } from 'lib/logic/featureFlagLogic'
+import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
 import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
 import { billingLogic } from 'scenes/billing/billingLogic'
 import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic'
@@ -239,13 +238,9 @@ export const onboardingLogic = kea<onboardingLogicType>([
             },
         ],
         shouldShowReverseProxyStep: [
-            (s) => [s.product, s.featureFlags, s.productKey],
-            (_product, featureFlags: FeatureFlagsSet, productKey) => {
-                const productsWithReverseProxy = []
-                if (featureFlags[FEATURE_FLAGS.REVERSE_PROXY_ONBOARDING] === 'test') {
-                    productsWithReverseProxy.push(ProductKey.FEATURE_FLAGS)
-                }
-                return productsWithReverseProxy.includes(productKey as ProductKey)
+            (s) => [s.productKey],
+            (productKey) => {
+                return productKey && [ProductKey.FEATURE_FLAGS].includes(productKey as ProductKey)
             },
         ],
         isStepKeyInvalid: [