fix: Remove default of -7d for comparefilter

This is breaking some of our code and it's also a bad default
PostHog · Dec 13, 2024 · 3060585 · 3060585
1 parent 6a869bb
commit 3060585
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/frontend/src/queries/schema.json b/frontend/src/queries/schema.json
@@ -3792,7 +3792,6 @@
                     "type": "boolean"
                 },
                 "compare_to": {
-                    "default": "-7d",
                     "description": "The date range to compare to. The value is a relative date. Examples of relative dates are: `-1y` for 1 year ago, `-14m` for 14 months ago, `-100w` for 100 weeks ago, `-14d` for 14 days ago, `-30h` for 30 hours ago.",
                     "type": "string"
                 }

diff --git a/frontend/src/queries/schema.ts b/frontend/src/queries/schema.ts
@@ -1180,7 +1180,6 @@ export interface CompareFilter {
 
     /**
      * The date range to compare to. The value is a relative date. Examples of relative dates are: `-1y` for 1 year ago, `-14m` for 14 months ago, `-100w` for 100 weeks ago, `-14d` for 14 days ago, `-30h` for 30 hours ago.
-     * @default -7d
      */
     compare_to?: string
 }

diff --git a/posthog/schema.py b/posthog/schema.py
@@ -526,7 +526,7 @@ class CompareFilter(BaseModel):
         default=False, description="Whether to compare the current date range to a previous date range."
     )
     compare_to: Optional[str] = Field(
-        default="-7d",
+        default=None,
         description=(
             "The date range to compare to. The value is a relative date. Examples of relative dates are: `-1y` for 1"
             " year ago, `-14m` for 14 months ago, `-100w` for 100 weeks ago, `-14d` for 14 days ago, `-30h` for 30"
-Original file line number
+Diff line change
@@ Expand Up / @@ -1180,7 +1180,6 @@ export interface CompareFilter { @@
         /**
          * The date range to compare to. The value is a relative date. Examples of relative dates are: `-1y` for 1 year ago, `-14m` for 14 months ago, `-100w` for 100 weeks ago, `-14d` for 14 days ago, `-30h` for 30 hours ago.
-         * @default -7d
          */
         compare_to?: string
     }
@@ Expand Down @@