Skip to content

Commit

Permalink
fix: Bump timeout but reduce heartbeat timeout (#17670)
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasfarias authored Sep 28, 2023
1 parent e4de9f0 commit 300193c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions posthog/api/test/__snapshots__/test_person.ambr
Original file line number Diff line number Diff line change
Expand Up @@ -1252,8 +1252,8 @@
(SELECT id
FROM person
WHERE team_id = 2
AND ((replaceRegexpAll(JSONExtractRaw(properties, 'email'), '^"|"$', '') ILIKE '%00000000-0000-4000-8000-000000000001%')
OR (id = '00000000-0000-4000-8000-000000000001'
AND ((replaceRegexpAll(JSONExtractRaw(properties, 'email'), '^"|"$', '') ILIKE '%00000000-0000-4000-8000-000000000000%')
OR (id = '00000000-0000-4000-8000-000000000000'
OR id IN
(SELECT person_id
FROM
Expand All @@ -1263,12 +1263,12 @@
WHERE team_id = 2
GROUP BY distinct_id
HAVING argMax(is_deleted, version) = 0)
WHERE distinct_id = '00000000-0000-4000-8000-000000000001' ))) )
WHERE distinct_id = '00000000-0000-4000-8000-000000000000' ))) )
GROUP BY id
HAVING max(is_deleted) = 0
AND argMax(person.created_at, version) < now() + INTERVAL 1 DAY
AND ((replaceRegexpAll(JSONExtractRaw(argMax(person.properties, version), 'email'), '^"|"$', '') ILIKE '%00000000-0000-4000-8000-000000000001%')
OR (id = '00000000-0000-4000-8000-000000000001'
AND ((replaceRegexpAll(JSONExtractRaw(argMax(person.properties, version), 'email'), '^"|"$', '') ILIKE '%00000000-0000-4000-8000-000000000000%')
OR (id = '00000000-0000-4000-8000-000000000000'
OR id IN
(SELECT person_id
FROM
Expand All @@ -1278,7 +1278,7 @@
WHERE team_id = 2
GROUP BY distinct_id
HAVING argMax(is_deleted, version) = 0)
WHERE distinct_id = '00000000-0000-4000-8000-000000000001' )))
WHERE distinct_id = '00000000-0000-4000-8000-000000000000' )))
ORDER BY argMax(person.created_at, version) DESC, id DESC
LIMIT 100) person
LEFT JOIN
Expand Down
4 changes: 2 additions & 2 deletions posthog/temporal/workflows/s3_batch_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,8 @@ async def run(self, inputs: S3BatchExportInputs):
await workflow.execute_activity(
insert_into_s3_activity,
insert_inputs,
start_to_close_timeout=dt.timedelta(minutes=10),
heartbeat_timeout=dt.timedelta(minutes=10),
start_to_close_timeout=dt.timedelta(minutes=20),
heartbeat_timeout=dt.timedelta(minutes=2),
retry_policy=RetryPolicy(
initial_interval=dt.timedelta(seconds=10),
maximum_interval=dt.timedelta(seconds=120),
Expand Down

0 comments on commit 300193c

Please sign in to comment.