Skip to content

Commit

Permalink
chore(insights): Clean up insight details (#16322)
Browse files Browse the repository at this point in the history
* chore(insights): Clean up insight details

* Fix pre-commit performance

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
Twixes and github-actions[bot] authored Jul 4, 2023
1 parent 7b3eec5 commit 2fbf808
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# Check if staged files contain any added or modified PNGs - skip when merging
if \
! git rev-parse -q --verify MERGE_HEAD \
git rev-parse -q --verify MERGE_HEAD \
&& git diff --cached --name-status | grep '^[AM]' | grep -q '.png$'
then
# Error if OptiPNG is not installed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
font-size: 0.6875rem;
font-weight: 600;
line-height: 1rem;
vertical-align: -0.375em;
&.SeriesDisplay__raw-name--action,
&.SeriesDisplay__raw-name--event {
padding: 0.25rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export function TaxonomicBreakdownFilter({ filters, setFilters }: TaxonomicBreak
breakdownFilter={filters}
display={(filters as TrendsFilterType).display}
isTrends={filters.insight === InsightType.TRENDS}
updateBreakdown={(breakdownFilter) => setFilters?.(breakdownFilter, true)}
updateDisplay={(display) => setFilters?.({ display } as TrendsFilterType, true)}
updateBreakdown={setFilters ? (breakdownFilter) => setFilters(breakdownFilter, true) : undefined}
updateDisplay={setFilters ? (display) => setFilters({ display } as TrendsFilterType, true) : undefined}
/>
)
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 2fbf808

Please sign in to comment.