chore: add one forgotten metric (#27406)

PostHog · Jan 10, 2025 · 2ec15d9 · 2ec15d9
1 parent 468f340
commit 2ec15d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/rust/cymbal/src/frames/resolver.rs b/rust/cymbal/src/frames/resolver.rs
@@ -6,7 +6,7 @@ use sqlx::PgPool;
 use crate::{
     config::Config,
     error::UnhandledError,
-    metric_consts::{FRAME_CACHE_HITS, FRAME_CACHE_MISSES, FRAME_DB_HITS},
+    metric_consts::{FRAME_CACHE_HITS, FRAME_CACHE_MISSES, FRAME_DB_HITS, FRAME_DB_MISSES},
     symbol_store::{saving::SymbolSetRecord, Catalog},
 };
 
@@ -49,6 +49,8 @@ impl Resolver {
             return Ok(result.contents);
         }
 
+        metrics::counter!(FRAME_DB_MISSES).increment(1);
+
         let resolved = frame.resolve(team_id, catalog).await?;
 
         let set = if let Some(set_ref) = frame.symbol_set_ref() {

diff --git a/rust/cymbal/src/metric_consts.rs b/rust/cymbal/src/metric_consts.rs
@@ -24,6 +24,7 @@ pub const FRAME_RESOLVED: &str = "cymbal_frame_resolved";
 pub const FRAME_CACHE_HITS: &str = "cymbal_frame_cache_hits";
 pub const FRAME_CACHE_MISSES: &str = "cymbal_frame_cache_misses";
 pub const FRAME_DB_HITS: &str = "cymbal_frame_db_hits";
+pub const FRAME_DB_MISSES: &str = "cymbal_frame_db_misses";
 pub const FRAME_NOT_RESOLVED: &str = "cymbal_frame_not_resolved";
 pub const S3_FETCH: &str = "cymbal_s3_fetch";
 pub const S3_PUT: &str = "cymbal_s3_put";