Skip to content

Commit

Permalink
chore: rename existing recordings logic
Browse files Browse the repository at this point in the history
  • Loading branch information
daibhin committed Jun 17, 2024
1 parent 0ac37ae commit 2e1aae5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions frontend/src/scenes/session-recordings/SessionRecordings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ import { createPlaylist } from './playlist/playlistUtils'
import { SessionRecordingsPlaylist } from './playlist/SessionRecordingsPlaylist'
import { SavedSessionRecordingPlaylists } from './saved-playlists/SavedSessionRecordingPlaylists'
import { savedSessionRecordingPlaylistsLogic } from './saved-playlists/savedSessionRecordingPlaylistsLogic'
import { humanFriendlyTabName, sessionRecordingsLogic } from './sessionRecordingsLogic'
import { humanFriendlyTabName, sessionReplaySceneLogic } from './sessionReplaySceneLogic'

function Header(): JSX.Element {
const { guardAvailableFeature } = useValues(upgradeModalLogic)
const playlistsLogic = savedSessionRecordingPlaylistsLogic({ tab: ReplayTabs.Recent })
const { playlists } = useValues(playlistsLogic)
const { tab } = useValues(sessionRecordingsLogic)
const { tab } = useValues(sessionReplaySceneLogic)
const { currentTeam } = useValues(teamLogic)
const recordingsDisabled = currentTeam && !currentTeam?.session_recording_opt_in
const { reportRecordingPlaylistCreated } = useActions(eventUsageLogic)
Expand Down Expand Up @@ -176,7 +176,7 @@ function Warnings(): JSX.Element {
}

function MainPanel(): JSX.Element {
const { tab } = useValues(sessionRecordingsLogic)
const { tab } = useValues(sessionReplaySceneLogic)

return (
<div className="space-y-2">
Expand All @@ -198,7 +198,7 @@ function MainPanel(): JSX.Element {
}

function PageTabs(): JSX.Element {
const { tab, tabs } = useValues(sessionRecordingsLogic)
const { tab, tabs } = useValues(sessionReplaySceneLogic)

return (
<LemonTabs
Expand All @@ -225,5 +225,5 @@ export function SessionsRecordings(): JSX.Element {

export const scene: SceneExport = {
component: SessionsRecordings,
logic: sessionRecordingsLogic,
logic: sessionReplaySceneLogic,
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { openBillingPopupModal } from 'scenes/billing/BillingPopup'
import { toLocalFilters } from 'scenes/insights/filters/ActionFilter/entityFilterLogic'
import { getDisplayNameFromEntityFilter } from 'scenes/insights/utils'
import { DEFAULT_RECORDING_FILTERS } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'
import { PLAYLIST_LIMIT_REACHED_MESSAGE } from 'scenes/session-recordings/sessionRecordingsLogic'
import { PLAYLIST_LIMIT_REACHED_MESSAGE } from 'scenes/session-recordings/sessionReplaySceneLogic'
import { urls } from 'scenes/urls'

import { cohortsModelType } from '~/models/cohortsModelType'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { urls } from 'scenes/urls'
import { ActivityFilters } from '~/layout/navigation-3000/sidepanel/panels/activity/activityForSceneLogic'
import { ActivityScope, Breadcrumb, ReplayTabs } from '~/types'

import type { sessionRecordingsLogicType } from './sessionRecordingsLogicType'
import type { sessionReplaySceneLogic } from './sessionReplaySceneLogic'

Check failure on line 12 in frontend/src/scenes/session-recordings/sessionReplaySceneLogic.ts

View workflow job for this annotation

GitHub Actions / Code quality checks

Individual declarations in merged declaration 'sessionReplaySceneLogic' must be all exported or all local.

Check failure on line 12 in frontend/src/scenes/session-recordings/sessionReplaySceneLogic.ts

View workflow job for this annotation

GitHub Actions / Code quality checks

Import declaration conflicts with local declaration of 'sessionReplaySceneLogic'.

export const humanFriendlyTabName = (tab: ReplayTabs): string => {
switch (tab) {
Expand All @@ -24,8 +24,8 @@ export const humanFriendlyTabName = (tab: ReplayTabs): string => {

export const PLAYLIST_LIMIT_REACHED_MESSAGE = `You have reached the free limit of ${SESSION_RECORDINGS_PLAYLIST_FREE_COUNT} saved playlists`

export const sessionRecordingsLogic = kea<sessionRecordingsLogicType>([
path(() => ['scenes', 'session-recordings', 'root']),
export const sessionReplaySceneLogic = kea<sessionReplaySceneLogicType>([
path(() => ['scenes', 'session-recordings', 'sessionReplaySceneLogic']),
connect({

Check failure on line 29 in frontend/src/scenes/session-recordings/sessionReplaySceneLogic.ts

View workflow job for this annotation

GitHub Actions / Code quality checks

Individual declarations in merged declaration 'sessionReplaySceneLogic' must be all exported or all local.
values: [featureFlagLogic, ['featureFlags']],
}),
Expand Down

0 comments on commit 2e1aae5

Please sign in to comment.