Fix type issues

PostHog · Dec 6, 2023 · 2cb2e70 · 2cb2e70
1 parent 55a8199
commit 2cb2e70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.test.ts b/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.test.ts
@@ -167,9 +167,7 @@ describe('filtersToQueryNode', () => {
             const query: InsightQueryNode = {
                 kind: NodeKind.RetentionQuery,
                 filterTestAccounts: true,
-                retentionFilter: {},
-            }
-            result.retentionFilter = {} // Put this here to make TS happy
+            } as InsightQueryNode
             expect(result).toEqual(query)
         })
 
@@ -198,7 +196,6 @@ describe('filtersToQueryNode', () => {
 
             const query: InsightQueryNode = {
                 kind: NodeKind.RetentionQuery,
-                retentionFilter: {},
                 properties: {
                     type: FilterLogicalOperator.And,
                     values: [
@@ -215,8 +212,7 @@ describe('filtersToQueryNode', () => {
                         },
                     ],
                 },
-            }
-            result.retentionFilter = {} // Put this here to make TS happy
+            } as InsightQueryNode
             expect(result).toEqual(query)
         })
 
@@ -231,13 +227,11 @@ describe('filtersToQueryNode', () => {
 
             const query: InsightQueryNode = {
                 kind: NodeKind.RetentionQuery,
-                retentionFilter: {},
                 dateRange: {
                     date_to: '2021-12-08',
                     date_from: '2021-12-08',
                 },
-            }
-            result.retentionFilter = {} // Put this here to make TS happy
+            } as InsightQueryNode
             expect(result).toEqual(query)
         })
     })

diff --git a/posthog/hogql/test/test_property.py b/posthog/hogql/test/test_property.py
@@ -630,7 +630,7 @@ def test_entity_to_expr_events_type_without_id(self):
         self.assertEqual(result, ast.Constant(value=True))
 
     def test_entity_to_expr_default_case(self):
-        entity = RetentionEntity(**{"type": "other_type"})
+        entity = RetentionEntity()
         result = entity_to_expr(entity, default_event="default_event")
         expected = ast.CompareOperation(
             op=ast.CompareOperationOp.Eq,