Skip to content

Commit

Permalink
fix(data-warehouse): stop jitter on sync table (#26358)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
EDsCODE and github-actions[bot] authored Nov 25, 2024
1 parent e491803 commit 2beb224
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion frontend/src/lib/lemon-ui/LemonTable/LemonTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export interface LemonTableProps<T extends Record<string, any>> {
firstColumnSticky?: boolean
// Max width for the column headers
maxHeaderWidth?: string
/** Whether to hide the scrollbar. */
hideScrollbar?: boolean
}

export function LemonTable<T extends Record<string, any>>({
Expand Down Expand Up @@ -125,6 +127,7 @@ export function LemonTable<T extends Record<string, any>>({
footer,
firstColumnSticky,
maxHeaderWidth,
hideScrollbar,
}: LemonTableProps<T>): JSX.Element {
/** Search param that will be used for storing and syncing sorting */
const currentSortingParam = id ? `${id}_order` : 'order'
Expand Down Expand Up @@ -234,7 +237,11 @@ export function LemonTable<T extends Record<string, any>>({
style={style}
data-attr={dataAttr}
>
<ScrollableShadows direction="horizontal" scrollRef={scrollRef}>
<ScrollableShadows
innerClassName={hideScrollbar ? 'hide-scrollbar' : undefined}
direction="horizontal"
scrollRef={scrollRef}
>
<div className="LemonTable__content">
<table>
<colgroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const Syncs = ({ id }: SyncsProps): JSX.Element => {

return (
<LemonTable
hideScrollbar
dataSource={jobs}
loading={jobsLoading}
disableTableWhileLoading={false}
Expand Down

0 comments on commit 2beb224

Please sign in to comment.