fix: Check for the event generally being truthy (#17942)

PostHog · Oct 12, 2023 · 2bd2b2c · 2bd2b2c
1 parent 4a0796d
commit 2bd2b2c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/plugin-server/src/main/ingestion-queues/session-recording/session-recordings-consumer.ts b/plugin-server/src/main/ingestion-queues/session-recording/session-recordings-consumer.ts
@@ -310,9 +310,9 @@ export class SessionRecordingIngester {
             })
         }
 
-        const invalidEvents: RRWebEvent[] = []
+        const invalidEvents: any[] = []
         const events: RRWebEvent[] = $snapshot_items.filter((event: any) => {
-            if (!event.timestamp) {
+            if (!event || !event.timestamp) {
                 invalidEvents.push(event)
                 return false
             }

diff --git a/...-server/tests/main/ingestion-queues/session-recording/session-recordings-consumer.test.ts b/...-server/tests/main/ingestion-queues/session-recording/session-recordings-consumer.test.ts
@@ -309,6 +309,9 @@ describe('ingester', () => {
                     },
                 ],
             })
+
+            const parsedMessage3 = await ingester.parseKafkaMessage(createMessage([null]), () => Promise.resolve(1))
+            expect(parsedMessage3).toEqual(undefined)
         })
     })
-Original file line number
+Diff line change
@@ Expand Up / @@ -309,6 +309,9 @@ describe('ingester', () => { @@
                         },
                     ],
                 })
+                const parsedMessage3 = await ingester.parseKafkaMessage(createMessage([null]), () => Promise.resolve(1))
+                expect(parsedMessage3).toEqual(undefined)
             })
         })
@@ Expand Down @@