Skip to content

Commit

Permalink
Improve default apply_dashboard_filters support logic
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes committed Apr 25, 2024
1 parent 9d72c9f commit 29b55e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion posthog/hogql_queries/query_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ def _refresh_frequency(self):
def apply_dashboard_filters(self, dashboard_filter: DashboardFilter) -> Q:
# The default logic below applies to all insights and a lot of other queries
# Notable exception: `HogQLQuery`, which has `properties` and `dateRange` within `HogQLFilters`
if hasattr(self.query, "properties") and hasattr(self.query, "dateRange"):
if "properties" in self.query.model_fields and "dateRange" in self.query.model_fields:
query_update: dict[str, Any] = {}
if dashboard_filter.properties:
if self.query.properties:
Expand Down

0 comments on commit 29b55e9

Please sign in to comment.