Skip to content

Commit

Permalink
feat: Frontend support for endpoint_url
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasfarias committed Mar 12, 2024
1 parent b3c46a3 commit 2610234
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
9 changes: 9 additions & 0 deletions frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,15 @@ export function BatchExportsEditFields({
)}
</div>

<LemonField
name="endpoint_url"
label="Endpoint URL"
showOptional
info={<>Only required if exporting to an S3-compatible blob storage (like MinIO)</>}
>
<LemonInput placeholder={isNew ? 'e.g. https://your-minio-host:9000' : 'Leave unchanged'} />
</LemonField>

<LemonField name="exclude_events" label="Events to exclude" className="flex-1">
<LemonSelectMultiple
mode="multiple-custom"
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/batch_exports/batchExportEditLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export const batchExportFormFields = (
kms_key_id: !config.kms_key_id && config.encryption == 'aws:kms' ? 'This field is required' : '',
exclude_events: '',
include_events: '',
endpoint_url: null,
}
: destination === 'BigQuery'
? {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3587,6 +3587,7 @@ export type BatchExportDestinationS3 = {
compression: string | null
encryption: string | null
kms_key_id: string | null
endpoint_url: string | null
}
}

Expand Down

0 comments on commit 2610234

Please sign in to comment.