fix: handle unexpected shaped test account filters (#27068)

PostHog · Dec 20, 2024 · 25ebebc · 25ebebc
1 parent 7d35d2b
commit 25ebebc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/posthog/session_recordings/queries/session_recording_list_from_query.py b/posthog/session_recordings/queries/session_recording_list_from_query.py
@@ -182,7 +182,7 @@ def __init__(
     def _test_account_filters(self) -> list[AnyPropertyFilter]:
         prop_filters: list[AnyPropertyFilter] = []
         for prop in self._team.test_account_filters:
-            match prop["type"]:
+            match prop.get("type", None):
                 case "person":
                     prop_filters.append(PersonPropertyFilter(**prop))
                 case "event":
@@ -191,6 +191,9 @@ def _test_account_filters(self) -> list[AnyPropertyFilter]:
                     prop_filters.append(GroupPropertyFilter(**prop))
                 case "hogql":
                     prop_filters.append(HogQLPropertyFilter(**prop))
+                case None:
+                    logger.warn("test account filter had no type", filter=prop)
+                    prop_filters.append(EventPropertyFilter(**prop))
 
         return prop_filters
 

diff --git a/posthog/session_recordings/queries/test/test_session_recording_list_from_query.py b/posthog/session_recordings/queries/test/test_session_recording_list_from_query.py
@@ -3316,7 +3316,9 @@ def test_event_filter_with_test_accounts_excluded(self):
                 "key": "is_internal_user",
                 "value": ["false"],
                 "operator": "exact",
-                "type": "event",
+                # in production some test account filters don't include type
+                # we default to event in that case
+                # "type": "event",
             },
             {"key": "properties.$browser == 'Chrome'", "type": "hogql"},
         ]