Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
daibhin committed Sep 14, 2023
1 parent 6089563 commit 22fa6c3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions frontend/src/scenes/experiments/SecondaryMetrics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,16 @@ export function SecondaryMetrics({
mathAvailability={MathAvailability.None}
buttonCopy="Add funnel step"
seriesIndicatorType="numeric"
sortable={true}
showNestedArrow={true}
sortable
showNestedArrow
propertiesTaxonomicGroupTypes={[
TaxonomicFilterGroupType.EventProperties,
TaxonomicFilterGroupType.PersonProperties,
TaxonomicFilterGroupType.EventFeatureFlags,
TaxonomicFilterGroupType.Cohorts,
TaxonomicFilterGroupType.Elements,
]}
readOnly={true}
readOnly
/>
)}
{metric.filters.insight === InsightType.TRENDS && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ export function FunnelsQuerySteps({ insightProps }: EditorFilterProps): JSX.Elem
showSeriesIndicator={showSeriesIndicator}
seriesIndicatorType="numeric"
entitiesLimit={FUNNEL_STEP_COUNT_LIMIT}
sortable={true}
showNestedArrow={true}
sortable
showNestedArrow
propertiesTaxonomicGroupTypes={[
TaxonomicFilterGroupType.EventProperties,
TaxonomicFilterGroupType.PersonProperties,
Expand Down

0 comments on commit 22fa6c3

Please sign in to comment.