Skip to content

Commit

Permalink
fix(experiments): Prevent double taxonomic filter popup when creating (
Browse files Browse the repository at this point in the history
  • Loading branch information
neilkakkar authored Feb 13, 2024
1 parent 57b2988 commit 2125e8b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion frontend/src/scenes/experiments/MetricSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function ExperimentInsightCreator({ insightProps }: { insightProps: Insig
),
} as TrendsQuery | FunnelsQuery)
}}
typeKey={`experiment-${isTrends ? InsightType.TRENDS : InsightType.FUNNELS}-secondary-metric`}
typeKey={`experiment-${isTrends ? InsightType.TRENDS : InsightType.FUNNELS}-${
insightProps.dashboardItemId
}-metric`}
mathAvailability={isTrends ? undefined : MathAvailability.None}
hideDeleteBtn={isTrends || filterSteps.length === 1}
buttonCopy={isTrends ? 'Add graph series' : 'Add funnel step'}
Expand Down

0 comments on commit 2125e8b

Please sign in to comment.