Skip to content

Commit

Permalink
fix(hogql): fix breaking down by feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Mar 13, 2024
1 parent f0f230e commit 1d3270f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions posthog/hogql_queries/insights/funnels/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ def get_breakdown_expr(
breakdown: List[str | int] | None, properties_column: str, normalize_url: bool | None = False
) -> ast.Expr:
if isinstance(breakdown, str) or isinstance(breakdown, int) or breakdown is None:
return parse_expr(f"ifNull({properties_column}.{breakdown}, '')")
return parse_expr(f"ifNull({properties_column}.\"{breakdown}\", '')")
else:
exprs = []
for b in breakdown:
expr = parse_expr(normalize_url_breakdown(f"ifNull({properties_column}.{b}, '')", normalize_url))
expr = parse_expr(normalize_url_breakdown(f"ifNull({properties_column}.\"{b}\", '')", normalize_url))
exprs.append(expr)
expression = ast.Array(exprs=exprs)

Expand Down

0 comments on commit 1d3270f

Please sign in to comment.