fix(surveys): display thank you message null state bug fix (#20284)

getting property of null bug fix
PostHog · Feb 13, 2024 · 17e92ef · 17e92ef
1 parent c1ffba5
commit 17e92ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/src/scenes/surveys/SurveyEdit.tsx b/frontend/src/scenes/surveys/SurveyEdit.tsx
@@ -201,7 +201,7 @@ export default function SurveyEdit(): JSX.Element {
                                                             ),
                                                         })
                                                     ),
-                                                    ...(survey.appearance.displayThankYouMessage
+                                                    ...(survey.appearance?.displayThankYouMessage
                                                         ? [
                                                               {
                                                                   key: survey.questions.length,
@@ -322,7 +322,7 @@ export default function SurveyEdit(): JSX.Element {
                                                 </Link>
                                             )}
                                         </div>
-                                        {!survey.appearance.displayThankYouMessage && (
+                                        {!survey.appearance?.displayThankYouMessage && (
                                             <LemonButton
                                                 type="secondary"
                                                 className="w-max mt-2"

diff --git a/frontend/src/scenes/surveys/SurveyFormAppearance.tsx b/frontend/src/scenes/surveys/SurveyFormAppearance.tsx
@@ -19,7 +19,7 @@ export function SurveyFormAppearance({
     setActivePreview,
     isEditingSurvey,
 }: SurveyFormAppearanceProps): JSX.Element {
-    const showThankYou = survey.appearance.displayThankYouMessage && activePreview >= survey.questions.length
+    const showThankYou = survey.appearance?.displayThankYouMessage && activePreview >= survey.questions.length
 
     return survey.type !== SurveyType.API ? (
         <>
@@ -48,7 +48,7 @@ export function SurveyFormAppearance({
                         label: `${index + 1}. ${question.question ?? ''}`,
                         value: index,
                     })),
-                    ...(survey.appearance.displayThankYouMessage
+                    ...(survey.appearance?.displayThankYouMessage
                         ? [
                               {
                                   label: `${survey.questions.length + 1}. Confirmation message`,