fix: alert checked prometheus counter (#25356)

PostHog · Oct 3, 2024 · 1769b26 · 1769b26
1 parent 4d40e83
commit 1769b26
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/frontend/src/lib/components/Alerts/views/Alerts.tsx b/frontend/src/lib/components/Alerts/views/Alerts.tsx
@@ -83,7 +83,7 @@ export function Alerts({ alertId }: AlertsProps): JSX.Element {
                         to={urls.insightView(insight.short_id)}
                         title={
                             <Tooltip title={insight.name}>
-                                <div>{insight.name ?? insight.derived_name}</div>
+                                <div>{insight.name || insight.derived_name}</div>
                             </Tooltip>
                         }
                     />

diff --git a/posthog/tasks/alerts/checks.py b/posthog/tasks/alerts/checks.py
@@ -75,7 +75,7 @@ class TrendResult(TypedDict):
 ALERT_CHECKED_COUNTER = Counter(
     "alerts_checked",
     "Number of alerts we tried to check",
-    labelnames=["interval"],
+    labelnames=["calculation_interval"],
 )
 
 
@@ -215,7 +215,7 @@ def check_alert(alert_id: str) -> None:
         logger.warning("Alert not found or not enabled", alert_id=alert_id)
         return
 
-    ALERT_CHECKED_COUNTER.labels(interval=alert.calculation_interval).inc()
+    ALERT_CHECKED_COUNTER.labels(calculation_interval=alert.calculation_interval).inc()
 
     now = datetime.now(UTC)
     if alert.next_check_at and alert.next_check_at > now: