Fixes

PostHog · Nov 14, 2023 · 170a95b · 170a95b
1 parent 7e9f7ef
commit 170a95b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelDocs.tsx b/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelDocs.tsx
@@ -80,7 +80,7 @@ export const SidePanelDocs = (): JSX.Element => {
                     targetBlank
                     onClick={() => closeSidePanel()}
                 >
-                    Open on posthog.com
+                    Open in new tab
                 </LemonButton>
             </SidePanelPaneHeader>
             <div className="relative flex-1">

diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/sidePanelDocsLogic.ts b/frontend/src/layout/navigation-3000/sidepanel/panels/sidePanelDocsLogic.ts
@@ -1,4 +1,4 @@
-import { actions, kea, reducers, path, listeners, connect, selectors } from 'kea'
+import { actions, kea, reducers, path, listeners, connect, selectors, afterMount, beforeUnmount } from 'kea'
 
 import type { sidePanelDocsLogicType } from './sidePanelDocsLogicType'
 import { sidePanelStateLogic } from '../sidePanelStateLogic'
@@ -75,12 +75,20 @@ export const sidePanelDocsLogic = kea<sidePanelDocsLogicType>([
         unmountIframe: () => {
             // Update the initialPath so that next time we load it is the same as last time
             actions.setInitialPath(values.currentPath ?? '/docs')
-
-            // TODO: Do we need to call this before the window unloads?
         },
 
         handleExternalUrl: ({ urlOrPath }) => {
             router.actions.push(getPathFromUrl(urlOrPath))
         },
     })),
+
+    afterMount(({ actions, cache }) => {
+        // Call actions.unmountIframe when the window unloads
+        cache.beforeUnload = () => actions.unmountIframe()
+        window.addEventListener('beforeunload', cache.beforeUnload)
+    }),
+
+    beforeUnmount(({ cache }) => {
+        window.removeEventListener('beforeunload', cache.beforeUnload)
+    }),
 ])