Skip to content

Commit

Permalink
Added missing flag for ingestion warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
benjackwhite committed Oct 26, 2023
1 parent 88e7377 commit 112b795
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { mswDecorator } from '~/mocks/browser'
import { mswDecorator, useFeatureFlags } from '~/mocks/browser'
import { Meta } from '@storybook/react'
import { useAvailableFeatures } from '~/mocks/features'
import { AvailableFeature } from '~/types'
Expand All @@ -9,6 +9,7 @@ import { App } from 'scenes/App'
import { DatabaseSchemaQueryResponse } from '~/queries/schema'
import { ingestionWarningsResponse } from './ingestion-warnings/__mocks__/ingestion-warnings-response'
import { dayjs } from 'lib/dayjs'
import { FEATURE_FLAGS } from 'lib/constants'

const MOCK_DATABASE: DatabaseSchemaQueryResponse = {
events: [
Expand Down Expand Up @@ -116,6 +117,7 @@ export function Database(): JSX.Element {
}

export function IngestionWarnings(): JSX.Element {
useFeatureFlags([FEATURE_FLAGS.INGESTION_WARNINGS_ENABLED])
useEffect(() => {
router.actions.push(urls.ingestionWarnings())
}, [])
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/scenes/data-management/DataManagementScene.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,7 @@ const dataManagementSceneLogic = kea<dataManagementSceneLogicType>({
const allTabs = Object.keys(tabs)

return allTabs.filter((x) => {
if (x === DataManagementTab.IngestionWarnings) {
return showWarningsTab
}
return true
return x === DataManagementTab.IngestionWarnings ? showWarningsTab : true
}) as DataManagementTab[]
},
],
Expand Down

0 comments on commit 112b795

Please sign in to comment.