feat: add NOT options for url targeting (#22653)

Co-authored-by: shawnlikescode <[email protected]> Co-authored-by: Neil Kakkar <[email protected]>
PostHog · Jun 14, 2024 · 0d78e0f · 0d78e0f
1 parent 6133af0
commit 0d78e0f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/frontend/src/scenes/surveys/constants.tsx b/frontend/src/scenes/surveys/constants.tsx
@@ -1,3 +1,5 @@
+import { allOperatorsMapping } from 'lib/utils'
+
 import {
     Survey,
     SurveyQuestionDescriptionContentType,
@@ -17,10 +19,14 @@ export const SurveyQuestionLabel = {
     [SurveyQuestionType.MultipleChoice]: 'Multiple choice select',
 }
 
+// Create SurveyUrlMatchTypeLabels using allOperatorsMapping
 export const SurveyUrlMatchTypeLabels = {
-    [SurveyUrlMatchType.Contains]: '∋ contains',
-    [SurveyUrlMatchType.Regex]: '∼ matches regex',
-    [SurveyUrlMatchType.Exact]: '= equals',
+    [SurveyUrlMatchType.Exact]: allOperatorsMapping[SurveyUrlMatchType.Exact],
+    [SurveyUrlMatchType.IsNot]: allOperatorsMapping[SurveyUrlMatchType.IsNot],
+    [SurveyUrlMatchType.Contains]: allOperatorsMapping[SurveyUrlMatchType.Contains],
+    [SurveyUrlMatchType.NotIContains]: allOperatorsMapping[SurveyUrlMatchType.NotIContains],
+    [SurveyUrlMatchType.Regex]: allOperatorsMapping[SurveyUrlMatchType.Regex],
+    [SurveyUrlMatchType.NotRegex]: allOperatorsMapping[SurveyUrlMatchType.NotRegex],
 }
 
 export const defaultSurveyAppearance = {

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -2615,9 +2615,12 @@ export interface Survey {
 }
 
 export enum SurveyUrlMatchType {
-    Exact = 'exact',
-    Contains = 'icontains',
-    Regex = 'regex',
+    Exact = PropertyOperator.Exact,
+    IsNot = PropertyOperator.IsNot,
+    Contains = PropertyOperator.IContains,
+    NotIContains = PropertyOperator.NotIContains,
+    Regex = PropertyOperator.Regex,
+    NotRegex = PropertyOperator.NotRegex,
 }
 
 export enum SurveyType {