fix: re-add background to tertiary button (#18911)

PostHog · Nov 29, 2023 · 0d6b5aa · 0d6b5aa
1 parent daac935
commit 0d6b5aa
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 12 deletions.
diff --git a/frontend/__snapshots__/lemon-ui-lemon-button--active--dark.png b/frontend/__snapshots__/lemon-ui-lemon-button--active--dark.png
diff --git a/frontend/__snapshots__/lemon-ui-lemon-button--active--light.png b/frontend/__snapshots__/lemon-ui-lemon-button--active--light.png
diff --git a/frontend/__snapshots__/lemon-ui-lemon-button--menu-buttons--dark.png b/frontend/__snapshots__/lemon-ui-lemon-button--menu-buttons--dark.png
diff --git a/frontend/__snapshots__/lemon-ui-lemon-button--menu-buttons--light.png b/frontend/__snapshots__/lemon-ui-lemon-button--menu-buttons--light.png
diff --git a/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss b/frontend/src/lib/lemon-ui/LemonButton/LemonButton3000.scss
@@ -239,7 +239,7 @@
 
             &:not([aria-disabled='true']):hover,
             &.LemonButton--active {
-                background-color: var(--bg-3000);
+                background-color: var(--glass-border-3000);
             }
         }
     }

diff --git a/frontend/src/scenes/settings/Settings.tsx b/frontend/src/scenes/settings/Settings.tsx
@@ -51,14 +51,7 @@ export function Settings({
                                             fullWidth
                                             active={selectedLevel === level && !selectedSectionId}
                                         >
-                                            <span
-                                                className={clsx(
-                                                    'text-muted-alt',
-                                                    level === selectedLevel && 'font-bold'
-                                                )}
-                                            >
-                                                {capitalizeFirstLetter(level)}
-                                            </span>
+                                            <span className="text-muted-alt">{capitalizeFirstLetter(level)}</span>
                                         </LemonButton>
 
                                         <ul className="space-y-px">

diff --git a/frontend/src/styles/vars.scss b/frontend/src/styles/vars.scss
@@ -127,7 +127,6 @@ $colors: (
     'secondary-3000-hover-light': #cfd1c2,
     'accent-3000-light': #eeefe9,
     'bg-3000-light': #f3f4ef,
-    'bg-hover-3000-light': #f3f4ef,
     'border-3000-light': #dadbd2,
     'border-bold-3000-light': #c1c2b9,
     'glass-bg-3000-light': #e4e5deb3,
@@ -162,10 +161,9 @@ $colors: (
     'secondary-3000-hover-dark': #575d77,
     'accent-3000-dark': #21242b,
     'bg-3000-dark': #1d1f27,
-    'bg-hover-3000-dark': #292b36,
     'border-3000-dark': #35373e,
     'border-bold-3000-dark': #3f4046,
-    'glass-bg-3000-dark': #21242bb3,
+    'glass-bg-3000-dark': #24262a99,
     'glass-border-3000-dark': var(--border-3000-dark),
     'link-3000-dark': #f1a82c,