chore(data-warehouse): add error handling to postgres modal form (#20159

) add error handling to postgres modal form
PostHog · Feb 6, 2024 · 0d55f92 · 0d55f92
1 parent 9a38a3d
commit 0d55f92
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/frontend/src/scenes/data-warehouse/external/forms/sourceFormLogic.ts b/frontend/src/scenes/data-warehouse/external/forms/sourceFormLogic.ts
@@ -84,6 +84,9 @@ export const sourceFormLogic = kea<sourceFormLogicType>([
         submitExternalDataSourceFailure: ({ error }) => {
             lemonToast.error(error?.message || 'Something went wrong')
         },
+        submitDatabaseSchemaFormFailure: ({ error }) => {
+            lemonToast.error(error?.message || 'Something went wrong')
+        },
         handleRedirect: async ({ kind, searchParams }) => {
             switch (kind) {
                 case 'hubspot': {

diff --git a/posthog/warehouse/api/external_data_source.py b/posthog/warehouse/api/external_data_source.py
@@ -341,7 +341,15 @@ def database_schema(self, request: Request, *arg: Any, **kwargs: Any):
                 data={"message": "Cannot use internal Postgres database"},
             )
 
-        result = get_postgres_schemas(host, port, database, user, password, schema)
+        try:
+            result = get_postgres_schemas(host, port, database, user, password, schema)
+        except Exception as e:
+            logger.exception("Could not fetch Postgres schemas", exc_info=e)
+            return Response(
+                status=status.HTTP_400_BAD_REQUEST,
+                data={"message": "Could not fetch Postgres schemas. Please check all connection details are valid."},
+            )
+
         result_mapped_to_options = [{"table": row, "should_sync": False} for row in result]
         return Response(status=status.HTTP_200_OK, data=result_mapped_to_options)