Skip to content

Commit

Permalink
Delete the persons test
Browse files Browse the repository at this point in the history
  • Loading branch information
robbie-c committed Oct 28, 2024
1 parent deb41db commit 09d9fad
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions posthog/hogql/database/schema/test/test_sessions_v1.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
APIBaseTest,
ClickhouseTestMixin,
_create_event,
_create_person,
ClickhouseDestroyTablesMixin,
)

Expand Down Expand Up @@ -166,37 +165,6 @@ def test_events_session_dot_channel_type(self):
"Paid Search",
)

def test_persons_and_sessions_on_events(self):
p1 = _create_person(distinct_ids=["d1"], team=self.team)
p2 = _create_person(distinct_ids=["d2"], team=self.team)

s1 = "session_test_persons_and_sessions_on_events_1"
s2 = "session_test_persons_and_sessions_on_events_2"

_create_event(
event="$pageview",
team=self.team,
distinct_id="d1",
properties={"$session_id": s1, "utm_source": "source1"},
)
_create_event(
event="$pageview",
team=self.team,
distinct_id="d2",
properties={"$session_id": s2, "utm_source": "source2"},
)

response = self.__execute(
parse_select(
"select events.person_id, session.$entry_utm_source from events where $session_id = {session_id} or $session_id = {session_id2} order by 2 asc",
placeholders={"session_id": ast.Constant(value=s1), "session_id2": ast.Constant(value=s2)},
),
)

[row1, row2] = response.results or []
self.assertEqual(row1, (p1.uuid, "source1"))
self.assertEqual(row2, (p2.uuid, "source2"))

@parameterized.expand([(BounceRatePageViewMode.UNIQ_URLS,), (BounceRatePageViewMode.COUNT_PAGEVIEWS,)])
def test_bounce_rate(self, bounceRatePageViewMode):
# person with 2 different sessions
Expand Down

0 comments on commit 09d9fad

Please sign in to comment.