fix(surveys): delete targeting_flag_filters field after setting targe…

…ting flag (#17664)
PostHog · Sep 28, 2023 · 082e406 · 082e406
1 parent 3678ae4
commit 082e406
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/posthog/api/survey.py b/posthog/api/survey.py
@@ -136,6 +136,9 @@ def create(self, validated_data):
             validated_data["targeting_flag_id"] = targeting_feature_flag.id
             validated_data.pop("targeting_flag_filters")
 
+        if "targeting_flag_filters" in validated_data:
+            validated_data.pop("targeting_flag_filters")
+
         validated_data["created_by"] = self.context["request"].user
         return super().create(validated_data)
 

diff --git a/posthog/api/test/test_survey.py b/posthog/api/test/test_survey.py
@@ -29,6 +29,7 @@ def test_can_create_basic_survey(self):
                 "description": "Get feedback on the new notebooks feature",
                 "type": "popover",
                 "questions": [{"type": "open", "question": "What do you think of the new notebooks feature?"}],
+                "targeting_flag_filters": None,
             },
             format="json",
         )