Fix one more leak

PostHog · Oct 16, 2023 · 03bf375 · 03bf375
1 parent a2db4da
commit 03bf375
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/hogql_parser/parser.cpp b/hogql_parser/parser.cpp
@@ -431,8 +431,10 @@ class HogQLParseTreeConverter : public HogQLParserBaseVisitor {
     PyObject* next_join = PyObject_GetAttrString(last_join, "next_join");
     while (!Py_IsNone(next_join)) {
       last_join = next_join;
+      Py_DECREF(next_join);
       next_join = PyObject_GetAttrString(last_join, "next_join");
     }
+    Py_DECREF(next_join);
     PyObject_SetAttrString(last_join, "next_join", join2);
     Py_DECREF(join2);
 
@@ -465,8 +467,10 @@ class HogQLParseTreeConverter : public HogQLParserBaseVisitor {
     PyObject* next_join = PyObject_GetAttrString(last_join, "next_join");
     while (!Py_IsNone(next_join)) {
       last_join = next_join;
+      Py_DECREF(next_join);
       next_join = PyObject_GetAttrString(last_join, "next_join");
     }
+    Py_DECREF(next_join);
     PyObject_SetAttrString(last_join, "next_join", join2);
     Py_DECREF(join2);