fix(hogql): do not traverse the entire table when looking at one field (

#20113)
PostHog · Feb 5, 2024 · 02bf353 · 02bf353
1 parent e634a5c
commit 02bf353
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/posthog/hogql/database/schema/event_sessions.py b/posthog/hogql/database/schema/event_sessions.py
@@ -66,6 +66,9 @@ def __init__(self, expr: ast.Expr):
     def visit_lazy_join_type(self, node: ast.LazyJoinType):
         self.contains_lazy_join = True
 
+    def visit_field_type(self, node: ast.FieldType):
+        self.visit(node.table_type)
+
 
 class WhereClauseExtractor:
     compare_operators: List[ast.Expr]

diff --git a/posthog/hogql/visitor.py b/posthog/hogql/visitor.py
@@ -144,7 +144,7 @@ def visit_field_alias_type(self, node: ast.FieldAliasType):
         self.visit(node.type)
 
     def visit_field_type(self, node: ast.FieldType):
-        self.visit(node.table_type)
+        pass
 
     def visit_select_query_type(self, node: ast.SelectQueryType):
         for expr in node.tables.values():