ci: Run core backend tests with both HogQL and legacy insights

PostHog · Apr 25, 2024 · 01e7bb3 · 01e7bb3
1 parent 06fe778
commit 01e7bb3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.github/actions/run-backend-tests/action.yml b/.github/actions/run-backend-tests/action.yml
@@ -12,7 +12,7 @@ inputs:
         description: ClickHouse server image tag, e.g. clickhouse/clickhouse-server:latest
     segment:
         required: true
-        description: Either 'Core' or 'Temporal' segment
+        description: Either 'Core', 'Legacy insights backend', or 'Temporal'
     concurrency:
         required: true
         description: Count of concurrency groups
@@ -145,12 +145,13 @@ runs:
           run: echo "PYTEST_ARGS=--snapshot-update" >> $GITHUB_ENV # We can only update snapshots within the PostHog org
 
         # Tests
-        - name: Run Core tests
+        - name: Run core tests
           id: run-core-tests
-          if: ${{ inputs.segment == 'Core' }}
+          if: ${{ inputs.segment != 'Temporal' }}
           env:
               PERSON_ON_EVENTS_V2_ENABLED: ${{ inputs.person-on-events }}
               GROUPS_ON_EVENTS_ENABLED: ${{ inputs.person-on-events }}
+              HOGQL_INSIGHTS_OVERRIDE: ${{ inputs.segment == 'Legacy insights backend' && 0 || 1 }}
           shell: bash
           run: | # async_migrations covered in ci-async-migrations.yml
               pytest ${{

diff --git a/.github/workflows/ci-backend.yml b/.github/workflows/ci-backend.yml
@@ -261,6 +261,12 @@ jobs:
                 concurrency: [10]
                 group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
                 include:
+                    - segment: 'Legacy insights backend'
+                      person-on-events: false
+                      clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.5.81-alpine'
+                      python-version: '3.10.10'
+                      concurrency: [10]
+                      group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
                     - segment: 'Temporal'
                       person-on-events: false
                       clickhouse-server-image: 'clickhouse/clickhouse-server:23.12.5.81-alpine'