Skip to content

Commit

Permalink
Revert "Provide a helpful message when the tests fail"
Browse files Browse the repository at this point in the history
This reverts commit 858d7b4.
  • Loading branch information
danielbachhuber committed Dec 16, 2024
1 parent dc9b7bb commit 00a4d64
Showing 1 changed file with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -907,11 +907,7 @@ def test_query_runner_with_data_warehouse_series_no_end_date_and_nested_id(self)

# Assert the expected join condition in the clickhouse SQL
expected_join_condition = f"and(equals(events.team_id, {query_runner.count_query_runner.team.id}), equals(event, %(hogql_val_8)s), greaterOrEquals(timestamp, assumeNotNull(parseDateTime64BestEffortOrNull(%(hogql_val_9)s, 6, %(hogql_val_10)s))), lessOrEquals(timestamp, assumeNotNull(parseDateTime64BestEffortOrNull(%(hogql_val_11)s, 6, %(hogql_val_12)s))))) AS e__events ON"
self.assertIn(
expected_join_condition,
str(response.clickhouse),
"Please make sure the timestamp statements are included in the ASOF LEFT JOIN select statement. The assertion may also fail if the hogql_val_* numbers have changed.",
)
self.assertIn(expected_join_condition, str(response.clickhouse))

result = query_runner.calculate()

Expand Down Expand Up @@ -1008,11 +1004,7 @@ def test_query_runner_with_data_warehouse_series_expected_query(self):

# Assert the expected join condition in the clickhouse SQL
expected_join_condition = f"and(equals(events.team_id, {query_runner.count_query_runner.team.id}), equals(event, %(hogql_val_7)s), greaterOrEquals(timestamp, assumeNotNull(parseDateTime64BestEffortOrNull(%(hogql_val_8)s, 6, %(hogql_val_9)s))), lessOrEquals(timestamp, assumeNotNull(parseDateTime64BestEffortOrNull(%(hogql_val_10)s, 6, %(hogql_val_11)s))))) AS e__events ON"
self.assertIn(
expected_join_condition,
str(response.clickhouse),
"Please make sure the timestamp statements are included in the ASOF LEFT JOIN select statement. The assertion may also fail if the hogql_val_* numbers have changed.",
)
self.assertIn(expected_join_condition, str(response.clickhouse))

result = query_runner.calculate()

Expand Down

0 comments on commit 00a4d64

Please sign in to comment.