Skip to content
Frontend CI

fix(surveys): polishing the popup survey UI #86703

Sign in to view logs

fix(surveys): polishing the popup survey UI

fix(surveys): polishing the popup survey UI #86703

Triggered via pull request July 3, 2024 20:57
@posthog-botposthog-bot
synchronize #23460
feat/popup-survey-ui-polish
Status Success
Total duration 9m 57s
Artifacts –

ci-frontend.yml

on: pull_request
Determine need to run frontend checks
8s
Determine need to run frontend checks
Code quality checks
9m 29s
Code quality checks
Matrix: jest
Fit to window
Zoom out
Zoom in

Annotations

18 warnings
Determine need to run frontend checks
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (EE - 2)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (FOSS - 2)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (EE - 3)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (FOSS - 1)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (EE - 1)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Jest test (FOSS - 3)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code quality checks
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code quality checks: frontend/src/layout/navigation-3000/sidepanel/panels/activity/sidePanelActivityLogic.tsx#L231
Unnecessary 'else' after 'return'
Code quality checks: frontend/src/layout/navigation/Breadcrumbs/breadcrumbsLogic.tsx#L86
Unnecessary 'else' after 'return'
Code quality checks: frontend/src/lib/components/Alerts/AlertsModal.tsx#L81
<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
Code quality checks: frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx#L140
<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
Code quality checks: frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx#L170
<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
Code quality checks: frontend/src/lib/components/Cards/TextCard/TextCard.tsx#L96
<LemonButtonWithDropdown> is forbidden, use <LemonMenu> with a <LemonButton> child instead
Code quality checks: frontend/src/lib/components/CommandBar/ActionInput.tsx#L20
Unnecessary 'else' after 'return'
Code quality checks: frontend/src/lib/components/CommandBar/SearchBarTab.tsx#L51
Unnecessary 'else' after 'return'
Code quality checks: frontend/src/lib/components/DefinitionPopover/definitionPopoverLogic.test.ts#L195
Avoid calling `expect` conditionally`
Code quality checks: frontend/src/lib/components/DefinitionPopover/definitionPopoverLogic.test.ts#L197
Avoid calling `expect` conditionally`