Skip to content
Backend CI

feat(performance): query improvements for trends (load less people) #88143

Sign in to view logs

feat(performance): query improvements for trends (load less people)

feat(performance): query improvements for trends (load less people) #88143

Triggered via pull request June 20, 2024 23:54
@posthog-botposthog-bot
synchronize #23135
aspicer/group_pdi
Status Failure
Total duration 11m 2s
Artifacts 5

ci-backend.yml

on: pull_request
Determine need to run backend checks
10s
Determine need to run backend checks
Matrix: async-migrations
Matrix: django
Python code quality checks
2m 23s
Python code quality checks
Validate Django and CH migrations
2m 41s
Validate Django and CH migrations
Calculate running time
0s
Calculate running time
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 28 warnings
Python code quality checks: posthog/hogql/database/schema/persons_pdi.py#L31
"SelectQuery" has no attribute "optimize_aggregation_in_order"
Python code quality checks: posthog/hogql/database/schema/persons.py#L69
Item "None" of "SelectQueryType | None" has no attribute "ctes"
Python code quality checks: posthog/hogql/database/schema/persons.py#L103
Item "None" of "SelectQueryType | None" has no attribute "ctes"
Python code quality checks: posthog/hogql/database/schema/persons.py#L106
List item 1 has incompatible type "AST"; expected "Expr"
Python code quality checks: posthog/hogql/database/schema/persons.py#L108
Incompatible types in assignment (expression has type "AST", variable has type "Expr | None")
Python code quality checks: posthog/hogql/database/schema/person_distinct_ids.py#L42
"SelectQuery" has no attribute "optimize_aggregation_in_order"
Python code quality checks: posthog/hogql_queries/actors_query_runner.py#L272
Item "HogQLQuery" of "InsightActorsQuery | FunnelsActorsQuery | FunnelCorrelationActorsQuery | HogQLQuery" has no attribute "source"
Python code quality checks: posthog/hogql_queries/insights/test/test_insight_actors_query_runner.py#L221
Argument 1 to "capture_queries" of "ClickhouseTestMixin" has incompatible type "Callable[[str], Match[str] | None]"; expected "Callable[[str], bool]"
Python code quality checks: posthog/hogql_queries/insights/test/test_insight_actors_query_runner.py#L221
Incompatible return value type (got "Match[str] | None", expected "bool")
Python code quality checks: posthog/hogql_queries/insights/test/test_insight_actors_query_runner.py#L248
Argument 1 to "capture_queries" of "ClickhouseTestMixin" has incompatible type "Callable[[str], Match[str] | None]"; expected "Callable[[str], bool]"
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (7/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (9/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (6/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (2/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (7/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (9/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (5/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (1/10)
Process completed with exit code 1.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (10/10)
Process completed with exit code 1.
Determine need to run backend checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Python code quality checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Validate Django and CH migrations
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Async migrations tests - clickhouse/clickhouse-server:23.12.5.81-alpine
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (7/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (10/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (2/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (3/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (1/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (4/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (8/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (5/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (6/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events on), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (9/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (6/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (8/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (2/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (3/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (3/10)
No files were found with the provided path: posthog/tasks/test/__emails__. No artifacts will be uploaded.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (7/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (4/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (4/10)
No files were found with the provided path: posthog/tasks/test/__emails__. No artifacts will be uploaded.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (9/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (5/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (1/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Temporal (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (1/1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Django tests – Core (persons-on-events off), Py 3.10.10, clickhouse/clickhouse-server:23.12.5.81-alpine (10/10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "email_renders". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
email_renders Expired
49.4 KB
timing_data-Core-3 Expired
129 KB
timing_data-Core-4 Expired
129 KB
timing_data-Core-8 Expired
135 KB
timing_data-Temporal-1 Expired
130 KB