Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom webfont selection on surveys #1643

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

lucasheriques
Copy link
Contributor

@lucasheriques lucasheriques commented Jan 7, 2025

Changes

Adds a new optional property to survey's appearance: fontFamily.

Keeps the current value as default to not break any existing surveys.

...

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 10, 2025 7:08pm

@posthog-bot
Copy link
Collaborator

Hey @lucasheriques! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

github-actions bot commented Jan 7, 2025

Size Change: +720 B (+0.02%)

Total Size: 3.23 MB

Filename Size Change
dist/all-external-dependencies.js 207 kB +90 B (+0.04%)
dist/array.full.es5.js 264 kB +90 B (+0.03%)
dist/array.full.js 366 kB +90 B (+0.02%)
dist/array.full.no-external.js 365 kB +90 B (+0.02%)
dist/module.full.js 366 kB +90 B (+0.02%)
dist/module.full.no-external.js 365 kB +90 B (+0.02%)
dist/surveys-preview.js 58.1 kB +90 B (+0.16%)
dist/surveys.js 63.8 kB +90 B (+0.14%)
ℹ️ View Unchanged
Filename Size
dist/array.js 180 kB
dist/array.no-external.js 179 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 181 kB
dist/module.js 180 kB
dist/module.no-external.js 179 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@lucasheriques lucasheriques force-pushed the feat/custom-webfont-selection-on-survey branch from 28395dd to fdae3df Compare January 10, 2025 17:30
@lucasheriques lucasheriques added the bump patch Bump patch version when this PR gets merged label Jan 10, 2025
@lucasheriques lucasheriques marked this pull request as ready for review January 10, 2025 17:32
@lucasheriques lucasheriques merged commit bf552f3 into main Jan 13, 2025
29 checks passed
@lucasheriques lucasheriques deleted the feat/custom-webfont-selection-on-survey branch January 13, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants