Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build against lowest and current version of TS #1625

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 19, 2024

i advised a customer to upgrade and they couldn't because we had an implicit minimum TS version, luckily they could upgrade without a major TS verson upgrade the friday before xmas by applying a minor update

let's test that discovered minimum so we know if we break it in future

we discovered you can't run tsc in a project lower than TS 4.7.2 that imports posthog
(for the benefit of folk coming across this issue - this doesn't affect JS projects or the HTML snippet)


this builds the library under different node versions and then imports it into a file and runs tsc on that file

here's that failing using the customer's too low version

Screenshot 2024-12-19 at 21 37 20

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 19, 2024 10:13pm

Copy link

github-actions bot commented Dec 19, 2024

Size Change: 0 B

Total Size: 3.22 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/array.full.es5.js 262 kB
dist/array.full.js 365 kB
dist/array.full.no-external.js 364 kB
dist/array.js 179 kB
dist/array.no-external.js 178 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/main.js 180 kB
dist/module.full.js 365 kB
dist/module.full.no-external.js 364 kB
dist/module.js 179 kB
dist/module.no-external.js 178 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra marked this pull request as ready for review December 19, 2024 21:51
@pauldambra pauldambra requested a review from a team December 19, 2024 21:51
@pauldambra pauldambra merged commit f1cf456 into main Dec 19, 2024
28 checks passed
@pauldambra pauldambra deleted the chore/build-on-multi-ts branch December 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants