Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load RemoteConfig by default but don't use it #1607

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

Part of the rollout testing. Because this is replacing decide we can't use decide to gradually rollout. Instead I'm turning it on for everyone but only using it if the preview flag is enabled. That way I can poke around implementations and see if its working as well as checking backend metrics

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite requested a review from a team December 16, 2024 13:12
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 16, 2024 2:05pm

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Dec 16, 2024
logger.warn('Remote config is disabled. Falling back to local config.')
return
}
try {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff is just the try catch and moving the "preview" check into the callback function

Copy link

github-actions bot commented Dec 16, 2024

Size Change: +1.36 kB (+0.04%)

Total Size: 3.22 MB

Filename Size Change
dist/array.full.es5.js 262 kB +136 B (+0.05%)
dist/array.full.js 365 kB +136 B (+0.04%)
dist/array.full.no-external.js 364 kB +136 B (+0.04%)
dist/array.js 179 kB +136 B (+0.08%)
dist/array.no-external.js 177 kB +136 B (+0.08%)
dist/main.js 180 kB +136 B (+0.08%)
dist/module.full.js 365 kB +136 B (+0.04%)
dist/module.full.no-external.js 364 kB +136 B (+0.04%)
dist/module.js 179 kB +136 B (+0.08%)
dist/module.no-external.js 178 kB +136 B (+0.08%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@benjackwhite benjackwhite merged commit 9b4c24e into main Dec 17, 2024
13 checks passed
@benjackwhite benjackwhite deleted the feat/remote-config-gradual-rollout branch December 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants