Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added domain param to config requests #1601

Closed
wants to merge 1 commit into from

Conversation

benjackwhite
Copy link
Collaborator

Changes

We need to pass the domain to do some extra validation (we need a query param due to CDN caching)

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Dec 12, 2024
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 12, 2024 5:35pm

Copy link

Size Change: +582 B (+0.02%)

Total Size: 3.21 MB

Filename Size Change
dist/array.full.es5.js 261 kB +36 B (+0.01%)
dist/array.full.js 364 kB +74 B (+0.02%)
dist/array.full.no-external.js 363 kB +37 B (+0.01%)
dist/array.js 178 kB +72 B (+0.04%)
dist/array.no-external.js 177 kB +36 B (+0.02%)
dist/external-scripts-loader.js 2.51 kB +36 B (+1.45%)
dist/main.js 179 kB +72 B (+0.04%)
dist/module.full.js 364 kB +74 B (+0.02%)
dist/module.full.no-external.js 363 kB +37 B (+0.01%)
dist/module.js 178 kB +72 B (+0.04%)
dist/module.no-external.js 177 kB +36 B (+0.02%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@benjackwhite benjackwhite changed the title Added domain param to config requests feat: Added domain param to config requests Dec 12, 2024
@benjackwhite benjackwhite deleted the feat/remote-config-authed-domains branch December 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant