chore(flags): Add new debugging property $used_bootstrap_value, $feature_flag_bootstrapped_response and $feature_flag_bootstrapped_payload to $feature_flag_called event
#1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response` and `$feature_flag_bootstrapped_payload` to `$feature_flag_called` event
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +5.21 kB (+0.16%) Total Size: 3.21 MB
ℹ️ View Unchanged
|
dmarticus
approved these changes
Dec 2, 2024
havenbarnes
added
bump minor
havenbarnes
changed the title
$feature_flag_bootstrapped_response and $feature_flag_bootstrapped_payload to $feature_flag_called event$used_bootstrap_value, $feature_flag_bootstrapped_response and $feature_flag_bootstrapped_payload to $feature_flag_called event
havenbarnes
commented
Dec 4, 2024
| @@ -32,6 +32,7 @@ describe('featureflags', () => { | |||
| get_property: (key) => instance.persistence.props[key], | |||
| capture: () => {}, | |||
| decideEndpointWasHit: false, | |||
| receivedFlagValues: false, | |||
There was a problem hiding this comment.
In this PR we are essentially find+replacing the existing flag decideEndpointWasHit for this new, more accurately named receivedFlagValues flag. The prior will now mean that the endpoint truly was hit with no errors, and the latter will mean that there are flag values available for the SDK to return.
decideEndpointWasHit is now really only used for passing back the $used_bootstrap_value flag in $feature_flag_called events.
|
@dmarticus added |
dmarticus
approved these changes
Dec 4, 2024
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
dmarticus
reviewed
Dec 9, 2024
testcafe/check-testcafe-results.js
Outdated
| @@ -47,7 +47,7 @@ If they seem to be failing unexpectedly, check grafana for ingestion lag at http | |||
| log(JSON.stringify(files, null, 2)) | |||
|
|
|||
| // the deadline is the same for each assert, as the ingestion lag will be happening in parallel | |||
| const deadline = Date.now() + 1000 * 60 * 30 // 30 minutes | |||
| const deadline = Date.now() + 1000 * 60 * 120 // 30 minutes | |||
There was a problem hiding this comment.
pedantic, but you should change the comment to match the time (it's 120 minutes now).
There was a problem hiding this comment.
I was hoping to not leave this around, but may do so depending on what others think
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Same change for bootstrapping as PostHog/posthog-js-lite#320
Checklist