fix: patch to angular detection in rrweb #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Nov 27, 2024
Comment on lines
+11
to
+19
| + try { | ||
| + if (!isFunction(x)) { | ||
| + return false; | ||
| + } | ||
| + const prototypeKeys = Object.getOwnPropertyNames(x.prototype || {}); | ||
| + return prototypeKeys.some((key) => key.indexOf('__zone')); | ||
| + } catch { | ||
| + // we've seen some intermittent problems in Safari since introducing this check | ||
| + return false |
There was a problem hiding this comment.
this is the new thing, so let's wrap it and return false
very speculative
pauldambra
commented
Nov 27, 2024
Comment on lines
+38
to
+43
| - if (!untaintedObject) return defaultPrototype; | ||
| + if (!untaintedObject) return defaultObj.prototype; | ||
| return untaintedBasePrototype$1[key] = untaintedObject; | ||
| } catch { | ||
| - return defaultPrototype; | ||
| + return defaultObj.prototype; |
There was a problem hiding this comment.
we return slightly different things on different lines
we didn't change this but it's nicer to always return the same thing
NB in a site where I could reproduce the problem it was if (!untaintedObject) return defaultPrototype; that was returning
|
Size Change: +357 B (+0.01%) Total Size: 3.17 MB
ℹ️ View Unchanged
|
marandaneto
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really hard to reproduce the bug, and in the one site where I can reproduce it it's really hard to debug what's happening.
Explanation in-line in the review, but this is an attempt to make this detection safer in Safari